Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5.0 RTC Native platforms] Release Notes&API Refs #1600

Closed
Suri539 opened this issue Nov 14, 2024 · 7 comments
Closed

[4.5.0 RTC Native platforms] Release Notes&API Refs #1600

Suri539 opened this issue Nov 14, 2024 · 7 comments
Assignees

Comments

@Suri539
Copy link

Suri539 commented Nov 14, 2024

Hi,

The v4.5.0 API refs and release notes for native platforms are ready. You can find the english source at this tag: https://github.com/AgoraIO/agora_doc_source/tree/v.4.5.0-native-source/dita/RTC-NG.

You can find the english release notes for native platforms in agora_doc_source/markdown/RTC 4.x/release-notes/en-US/native and do the editing work if needed.

For the English API ref, please see this PR: https://github.com/AgoraIO/agora_doc_source/pull/3828/files. We have made a quick review on the language. @atovpeko Please leave your comments on the PR if you find it is necessary to modify the wording. Thanks!

@saudsami
Copy link
Collaborator

Hi,
It seems that this tag does not include updates to the ditamap files in dita\RTC-NG\
Can you please check?

@Suri539
Copy link
Author

Suri539 commented Nov 19, 2024 via email

@Suri539
Copy link
Author

Suri539 commented Nov 25, 2024

Hi, a new API was required to be included in the RTC 4.5.0 native release on last Friday. Please ensure this newly-added API is also included in the EN docs.
The english source of this API: AgoraIO/agora_doc_source@4ac9bd8
The ditamap diff:
https://github.com/AgoraIO/agora_doc_source/pull/3840/files#diff-043357f3801caf9b9274647381b06f8d9ec592c43837c46698d069c65101b74b

@atovpeko atovpeko removed their assignment Nov 25, 2024
@saudsami
Copy link
Collaborator

Updated
There was a missing files in the api folder and some missing keys. I copied these from the CN folder to make it work.

@Suri539
Copy link
Author

Suri539 commented Nov 26, 2024

Updated There was a missing files in the api folder and some missing keys. I copied these from the CN folder to make it work.

Cool! Can you please give me a list of the missing files so that I can check the source to avoid this next time? Thanks!

BTW, there's another update on release notes and API:https://jira.agoralab.co/browse/ENDOC-575 request by the product manager. I'll update the english source later.

@saudsami
Copy link
Collaborator

saudsami commented Nov 26, 2024

The following file was missing:
en-US/dita/RTC-NG/API/api_rte_destroy.dita

The following files were missing the Destroy_Rte key:
en-US/dita/RTC-NG/config/keys-rtc-ng-api-cpp.ditamap
‎en-US/dita/RTC-NG/config/keys-rtc-ng-api-java.ditamap

Please let me know when the english source is updated.

@saudsami saudsami reopened this Nov 26, 2024
@Suri539
Copy link
Author

Suri539 commented Nov 27, 2024

The following file was missing: en-US/dita/RTC-NG/API/api_rte_destroy.dita

The following files were missing the Destroy_Rte key: en-US/dita/RTC-NG/config/keys-rtc-ng-api-cpp.ditamap ‎en-US/dita/RTC-NG/config/keys-rtc-ng-api-java.ditamap

Please let me know when the english source is updated.

The updated source is in #1602 and I've checked that the api_rte_destroy.dita file and maps can be found here: AgoraIO/agora_doc_source@v.4.5.0-native-source...4.5.0-API-update

@saudsami saudsami closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants