From 49310a08988bd3070ddecf540dd8bb472055a7d5 Mon Sep 17 00:00:00 2001 From: Casey Jao Date: Tue, 15 Aug 2023 14:08:45 -0400 Subject: [PATCH 1/2] Temporarily enable MacOS 12 / Python 3.8 / Dask test --- .github/workflows/test_matrix.json | 6 +++--- CHANGELOG.md | 1 + tests/functional_tests/workflow_stack_test.py | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test_matrix.json b/.github/workflows/test_matrix.json index 7edb7a3bf..0c9dfedeb 100644 --- a/.github/workflows/test_matrix.json +++ b/.github/workflows/test_matrix.json @@ -72,8 +72,6 @@ "backend": "dask", "experimental": false, "trigger": [ - "push", - "pull_request", "schedule", "workflow_dispatch" ] @@ -306,7 +304,9 @@ "backend": "dask", "experimental": false, "trigger": [ - "schedule", + "pull_request", + "push", + "schedule", "workflow_dispatch" ] }, diff --git a/CHANGELOG.md b/CHANGELOG.md index c8636c956..c8213ae5f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Operations +- Temporarily enable mac os test on push - Respecting node version as specified in `.nvmrc` file for tests workflow - Bumped versions in pre-commit config - Added prettier for markdown files. diff --git a/tests/functional_tests/workflow_stack_test.py b/tests/functional_tests/workflow_stack_test.py index fd2b0c438..7fb5219d0 100644 --- a/tests/functional_tests/workflow_stack_test.py +++ b/tests/functional_tests/workflow_stack_test.py @@ -496,6 +496,7 @@ def workflow(): rm._delete_result(dispatch_id) + assert workflow_result.error == "" assert workflow_result.status == Result.COMPLETED From 9211dffa466a6cfb68f5db0656beaea8c67d51f6 Mon Sep 17 00:00:00 2001 From: Casey Jao Date: Tue, 15 Aug 2023 17:08:53 -0400 Subject: [PATCH 2/2] Print error --- tests/functional_tests/workflow_stack_test.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/functional_tests/workflow_stack_test.py b/tests/functional_tests/workflow_stack_test.py index 7fb5219d0..216f8551b 100644 --- a/tests/functional_tests/workflow_stack_test.py +++ b/tests/functional_tests/workflow_stack_test.py @@ -496,6 +496,8 @@ def workflow(): rm._delete_result(dispatch_id) + print(workflow_result.get_node_result(0)["stderr"]) + print(workflow_result.get_node_result(0)["error"]) assert workflow_result.error == "" assert workflow_result.status == Result.COMPLETED