-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pennylane >=0.33.0 (and thereby newer versions of numpy) #1871
Comments
Looks like this is the offending line: covalent/covalent/_workflow/qdevice.py Line 45 in e45bd30
@kessler-frost: Is the |
@Andrew-S-Rosen so when creating a new device in Pennylane there are some attributes that the custom device is required to have, essentially describing what are all the operations and observables that this particular device supports as not all devices can physically support all operations/observables. This is why here we are simply making our device support whatever the default device supports. This is why you couldn't find it in the codebase 😅 because it's something that is required by pennylane when defining a custom device. |
@kessler-frost: Ah, that explains it! So then in order to resolve this issue, we basically need to swap out the required attributes (if any) and then would need to pin a lower-bound version on pennylane if I understand correctly. |
That is correct. |
Sorry @Andrew-S-Rosen , but I think this issue will be blocked by #1877 😓 . We don't currently have tests enabled for the qelectrons (which are the reason behind the Pennylane dependency), thus we cannot know whether upgrading to version 33 will break the feature or not (or if the feature has gotten broken due to a recent change yet). |
@kessler-frost: Makes perfect sense to me! I was admittedly relying blind on the test suite for this since I don't know anything about pennylane. I'll go ahead and close this! Edit: Oops, I thought this was a PR. The issue should still be kept open until it's resolved! |
I'd say even your PR should be open 😅 . I can comment on there once it's resolved. Until then you can keep it in draft mode instead I believe. |
Sounds good!! |
What should we add?
#1845 (comment)
Because of the above issue, the maximum version of pennylane is fixed (which also fixes the maximum version of numpy as a result). I'm opening an issue just so this is logged somewhere.
Describe alternatives you've considered.
No response
The text was updated successfully, but these errors were encountered: