Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export review data error when file name the same as project name #26

Open
Pnalson opened this issue May 22, 2018 · 2 comments
Open

Export review data error when file name the same as project name #26

Pnalson opened this issue May 22, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@Pnalson
Copy link

Pnalson commented May 22, 2018

The error cased by function

FileExportWrapper : FileExportWrapper(java.io.File file, String project)

this.path = p.substring(p.indexOf(project) + project.length(), p.indexOf(filename) - 1);

@postmann
Copy link
Member

Hi @Pnalson, great work! Thanks for reporting this bug AND submitting a suggestion for fixing it :) Can you create a pull request? Then I could create a new development release, test the fix and afterwards create a new release in a few days.

@postmann postmann changed the title Export reveiw data error when file name the same as project name Export review data error when file name the same as project name May 23, 2018
@postmann postmann added the bug label May 23, 2018
@postmann postmann self-assigned this May 23, 2018
@postmann postmann added this to the 0.9.3 milestone May 23, 2018
@Pnalson
Copy link
Author

Pnalson commented May 23, 2018

OK,I‘ll creat a pull request in a few days.
And I am thinking is it possible to change AgileReview record comments position by file lines, this could not change the reviewed files。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants