Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide cost and usage in playground and evaluation when these are not specified #1607

Merged
merged 9 commits into from
May 13, 2024
Merged

Hide cost and usage in playground and evaluation when these are not specified #1607

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ffb0c4f
added fallback value for null cost and usage values
bekossy May 3, 2024
dff89e0
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
bekossy May 4, 2024
76a5625
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
bekossy May 5, 2024
55e475b
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
bekossy May 6, 2024
2d9424b
minor changes
bekossy May 8, 2024
715ea9f
Added comments explaining currency formatting func
bekossy May 9, 2024
0263ffe
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
bekossy May 9, 2024
638384b
removed currency formatter conditional
bekossy May 9, 2024
6b2c66b
added fallback for null cost and usage values
bekossy May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agenta-web/src/lib/helpers/formatters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const intlNumber = new Intl.NumberFormat("en-US", {
const intlCurrency = new Intl.NumberFormat("en-US", {
style: "currency",
currency: "USD",
maximumFractionDigits: 4,
maximumFractionDigits: 6,
})

export const formatNumber = (value = 0) => {
Expand All @@ -14,7 +14,7 @@ export const formatNumber = (value = 0) => {

export const formatCurrency = (value: number) => {
bekossy marked this conversation as resolved.
Show resolved Hide resolved
if (value === 0) {
return "-"
return value
bekossy marked this conversation as resolved.
Show resolved Hide resolved
} else {
return intlCurrency.format(value)
}
Expand Down
Loading