Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variant selection from Create a new Test Set with JSON/CSV #629

Closed
kangsuhyun-yanolja opened this issue Sep 19, 2023 · 1 comment
Closed

Comments

@kangsuhyun-yanolja
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The variant dropdown is not visible in the 'Create a New Test Set with JSON/CSV' section and may not be necessary there. The dropdown seems more appropriate for the Endpoint section, so I suggest removing it from the 'Create a New Test Set with JSON/CSV' section.
스크린샷 2023-09-19 오후 3 11 57

Describe the solution you'd like
Remove the variant selection from the 'Create a New Test Set with JSON/CSV' section.

Additional context
I encountered this issue while working on PR #605 and have already removed it in that PR.
Please let me know if the variant should not be removed.

@mmabrouk
Copy link
Member

Thanks a lot @kangsuhyun-yanolja for noticing and solving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants