Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Allow template docker url to be modified via env #2075

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

[Enhancement]: Allow template docker url to be modified via env #2075

wants to merge 4 commits into from

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Sep 11, 2024 •
edited
Loading

Description

This PR allows the UI templates got from Docker hub to be flexible by allowing proxies to list the image tags.

Related Issue

Closes 1964

Related PR

Closed Contributor's PR

Changes

  • Update compose files to allow DOCKER_HUB_TEMPLATE_URL.
  • Make use of DOCKER_HUB_TEMPLATE_URL in templates_manager.update_and_sync_templates function.

What to QA

  • Run compose up and confirm that the templates are pulled from docker hub.
  • Create an app from the UI templates, navigate to the playground and run the variant.

Acceptance Tests

  • Ensure that templates are pulled and saved to the database.
  • Ensure that created apps from the UI templates works.

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 9:07am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 9:07am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 11, 2024
@dosubot dosubot bot added Backend enhancement New feature or request labels Sep 11, 2024
@aybruhm aybruhm mentioned this pull request Sep 11, 2024
Closed
@aybruhm aybruhm requested a review from jp-agenta September 11, 2024 09:24
@mmabrouk mmabrouk changed the base branch from main to dev December 11, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-agenta jp-agenta Awaiting requested review from jp-agenta

Assignees
No one assigned
Labels
Backend enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Docker URL for fetching Templates flexible
2 participants
@aybruhm @tarunwadhwa13