Bump Package version #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokvoid
reviewed
May 6, 2023
| @@ -1,6 +1,6 @@ | |||
| # Published at https://pypi.org/project/acryl-datahub/. | |||
| __package_name__ = "acryl-datahub-airflow-plugin" | |||
| __version__ = "0.10.1+affirm4" | |||
| __version__ = "0.10.1+affirm5" | |||
There was a problem hiding this comment.
Is there a point in bumping up these versions when there is really no change? Maybe we can just replace affirm4 on Artifactory?
There was a problem hiding this comment.
I noticed that when we don't bump up the version, make docker_image is not downloading the latest binary.
There was a problem hiding this comment.
Why do we need a docker image? This should just be the python package on Artifactory?
There was a problem hiding this comment.
Eventually packages have to be backed into a docker image. During docker image build all the Python packages will be downloaded from artifactory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the steps to build a package:
brew install librdkafka
brew tap adoptopenjdk/openjdk && brew install --cask adoptopenjdk8
export JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
cd metadata-ingestion
../gradlew :metadata-ingestion:installDev
source venv/bin/activate
pip install -e ".[base]"
./scripts/codegen.sh
python setup.py sdist bdist_wheel
twine upload -r artifactory dist/*
cd ../metadata-ingestion-modules/airflow-plugin/
python setup.py sdist bdist_wheel
twine upload -r artifactory dist/*
References:
https://github.com/datahub-project/datahub/blob/99b75e4d601b104db8039df92e54c88d3de28349/metadata-ingestion/developing.md
https://github.com/datahub-project/datahub/blob/99b75e4d601b104db8039df92e54c88d3de28349/docker/datahub-ingestion/Dockerfile#L25
https://github.com/datahub-project/datahub/blob/99b75e4d601b104db8039df92e54c88d3de28349/metadata-ingestion/scripts/codegen.sh