Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update template param to fix clang++ compiler errors #10

Closed
wants to merge 1 commit into from

Conversation

JerrySievert
Copy link

  • changes parameter name from mode to gmode, thus fixing clang++ compilation error, which is being masked by g++
  • my editor also cleaned up some whitespace, I can revert those changes if you require.

@JerrySievert
Copy link
Author

note, this fixes #5

@lnikj
Copy link

lnikj commented Jan 9, 2019

Just a confirmation that this builds OK here now too. Thanks Jerry.

Nice modules Aepelzens.

@Aepelzen
Copy link
Owner

Thanks, i appreciate the effort. But like i told you a year ago, this is not the right place for your fix. The parasites firmware is not part of this repository, it is included as a subtree. If you want this to be fixed you have to submit your patch to the parasites repository.
Also, I'm no longer maintaining this, so if you want any other fixes, feel free to fork.

@Aepelzen Aepelzen closed this Jan 17, 2019
@JerrySievert
Copy link
Author

I opened the PR because you have it directly committed into your repo - if you didn't, and instead used it as a submodule, I would have gone upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants