-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for domain.* TLD matching #48
Comments
core/pull-requests/1489 |
Testing instructions:
|
N.B.: I hate to necropost, but this seems to be the closest issue I can post this to w/o adding bunch of background info. Are y'all sure of this syntax? It seems like It seems like having explicit TLD/subdomain matchers (similar to |
@TPS Note, that TLD only means any domain from the public suffix list: https://publicsuffix.org/. |
The PSL seems to be an honorable resource, but comments like publicsuffix/list#1563 (comment) don't inspire confidence. Also,
Overall, this seems to be a similar problem to AdguardTeam/HttpsExclusions#24 |
PSL is not just a honorable resource, it is used by all browsers to detect domains that cannot have cookies. Anyways, I actually seem to be wrong here and we actually use ICANN at least in the browser extension.
The rule syntax cannot be linked to a particular company. The current definition is that when the domain is written as |
google.*##example.org
should match all thegoogle.TLD
domains.After that, add a task to AdguardKnowledgeBase -- this should be described there.
The text was updated successfully, but these errors were encountered: