Sharks - Philomena Kelly #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
May 25, 2022
| </section> | ||
|
|
||
| </main> | ||
| <footer><div class="bottom">(c) philomena</div></footer> |
There was a problem hiding this comment.
Careful with using div tags as a text container. They are used to divide collections of content.
Instead, let's use a p tag or other elements that are text-specific
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| <meta charset="UTF-8"> |
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Document</title> | ||
| <meta charset="UTF-8"> |
Comment on lines
+23
to
+31
| <div id="container"> | ||
|
|
||
|
|
||
| <div class="project"><h1>project</h1></div> | ||
| <div class="project"><h1>project</h1></div> | ||
| <div class="project"><h1>project</h1></div> | ||
|
|
||
|
|
||
| </div> |
There was a problem hiding this comment.
Let's make the div.container a section instead
Also there should only ever be one h1 per page, so perhaps h2 would be better here
| </div> | ||
|
|
||
| </main> | ||
| <footer>(c) philomena</footer> |
There was a problem hiding this comment.
Oops, you are missing your styling class like the other pages
Comment on lines
+18
to
+19
| /* object-position: 0% 10%; */ | ||
| /* filter: hue-rotate(300deg); */ |
There was a problem hiding this comment.
Suggested change
| /* object-position: 0% 10%; */ | |
| /* filter: hue-rotate(300deg); */ |
Comment on lines
+1
to
+12
|
|
||
|
|
||
| /* #hello { | ||
| background-color: lightpink; | ||
| top: 25%; | ||
| left: 0px; | ||
| position: absolute; | ||
| height: 50%; | ||
| width: 100%; | ||
| text-align: center; | ||
| } */ | ||
|
|
There was a problem hiding this comment.
Suggested change
| /* #hello { | |
| background-color: lightpink; | |
| top: 25%; | |
| left: 0px; | |
| position: absolute; | |
| height: 50%; | |
| width: 100%; | |
| text-align: center; | |
| } */ |
Comment on lines
+52
to
+67
| /* nav { | ||
| text-align: right; | ||
| background: none; | ||
| padding: none; | ||
|
|
||
| } | ||
|
|
||
| nav a { | ||
| text-decoration: none; | ||
| font-size: 20pt; | ||
| font-weight: lighter; | ||
| background: white; | ||
| padding-left: 20px; | ||
| line-height: 125%; | ||
| color: black; | ||
| } */ |
There was a problem hiding this comment.
Suggested change
| /* nav { | |
| text-align: right; | |
| background: none; | |
| padding: none; | |
| } | |
| nav a { | |
| text-decoration: none; | |
| font-size: 20pt; | |
| font-weight: lighter; | |
| background: white; | |
| padding-left: 20px; | |
| line-height: 125%; | |
| color: black; | |
| } */ |
Comment on lines
+25
to
+26
|
|
||
| /* background-color: yellow; */ |
There was a problem hiding this comment.
Suggested change
| /* background-color: yellow; */ |
| .name_container { | ||
| display: grid; | ||
| width: 700px; | ||
| /* background: grey; */ |
There was a problem hiding this comment.
Suggested change
| /* background: grey; */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions