Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign a number or name under the structure #75

Open
stan1233 opened this issue May 5, 2024 · 2 comments · May be fixed by #79
Open

Assign a number or name under the structure #75

stan1233 opened this issue May 5, 2024 · 2 comments · May be fixed by #79
Labels
category/new feature The feature will be added triage/confirm Accepted issue

Comments

@stan1233
Copy link

stan1233 commented May 5, 2024

What would you like to be added?

It would be great if, like most organic chemistry review journals, we could assign a number to the structure of compounds. I plan to draft in Obsidian.
image

Why is this needed?

No response
@stan1233 stan1233 added the triage The issue needs to be triaged label May 5, 2024
@stan1233 stan1233 changed the title Assign a number under the structure Assign a number or name under the structure May 5, 2024
@Acylation Acylation added triage/confirm Accepted issue and removed triage The issue needs to be triaged labels May 5, 2024
@Acylation
Copy link
Owner

In rdkit.js, we have a legend option and corresponding legendColour and legendFontSize settings.

Will check

  • If the smiles drawer package have the same
  • Where to store the legend info
  • Expose legend input on chem drawings

@Acylation Acylation added the category/new feature The feature will be added label May 5, 2024
@mimvoid
Copy link

mimvoid commented Dec 14, 2024

I've messed around with the plugin and made it work. The name property is valid syntax for SMILES parsers, including RDKit:

C1([Cl])=CC=CC(C(=O)O[OH])=C1 mCPBA

I'll look for an equivalent in smilesdrawer and clean some stuff up before making a pull request.

mimvoid added a commit to mimvoid/obsidian-chem that referenced this issue Dec 15, 2024
@mimvoid
Add name display for RDKit (Acylation#75)
d36f4af
@mimvoid mimvoid linked a pull request Dec 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/new feature The feature will be added triage/confirm Accepted issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to display names under compounds with RDKit mimvoid/obsidian-chem
3 participants
@stan1233 @Acylation @mimvoid