Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client.wait_for_start() #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yuhldr
Copy link

@yuhldr yuhldr commented Oct 23, 2024

wait_for_server -> wait_for_start


Important

Rename wait_for_server() to wait_for_start() in AFKWatcher.run() in afk.py.

  • Refactor:
    • Rename self.client.wait_for_server() to self.client.wait_for_start() in run() method of AFKWatcher class in afk.py.

This description was created by Ellipsis for d1ef106. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d1ef106 in 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_watcher_afk/afk.py:65
  • Draft comment:
    Ensure wait_for_start is a valid method of ActivityWatchClient. If not, this will cause a runtime error.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_D4XaEfpeI1u6xbHt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant