Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack VarOverride functionality doesn't work the slack url #251

Open
moadqassem opened this issue Feb 15, 2019 · 1 comment
Open

Slack VarOverride functionality doesn't work the slack url #251

moadqassem opened this issue Feb 15, 2019 · 1 comment

Comments

@moadqassem
Copy link
Contributor

Go version: go.11.1
OS: MacOS Mojave
Consul Version: 1.4.2
Consul-Alerts Version: 0.5.0

Description:

The main reason to use the VarOverrides is to have different notifiers paths. When I am using slack profile, the notifier variables are actually not overriden, the reason for that is, the url filed in the SlackNotifier is ignored. for example:

{
  "Interval": 10,
  "NotifList": {
    "slack":true
  },
  "VarOverrides": {
    "slack": {
      "url": "https://hooks.slack.com/xxx"
    }
  }
}```
@moadqassem
Copy link
Contributor Author

Here is the PR which fixes the issue: #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant