Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock grandpa and beefy rpc to allow P<>K bridge-init calls using chopsticks #681

Open
xlc opened this issue Mar 5, 2024 · 3 comments
Open

Comments

@xlc
Copy link
Member

xlc commented Mar 5, 2024

Context: paritytech/polkadot-sdk#3522

@serban300
Copy link

serban300 commented Mar 5, 2024

I think it is doable. However, Chopsticks is only a mocking client that doesn't actually finalize blocks using grandpa/beefy protocol so that it cannot provide real justifications.

There are two possible solutions:

1. Add a new feature to specify signing keys to Chopsticks so it can generate valid justifications.

2. Modify relayer to accept mock justifications. This will be useful to fork mainnet and run tests with it. As it is not possible to get real justifications from mainnet fork.

Let me know what do you think.

Also opened a tracking issue at Chopsticks AcalaNetwork/chopsticks#681

Thank you for opening this issue ! Moving the discussion here.

In the short term, mock or even empty finality proofs would help. We could probably modify the relayer and update the bridge hubs code to skip proof verification and run a basic test like this just to make sure that the rest of the functionality works. But it would be a complicated manual setup, and also it wouldn't cover everything.

So, in the long run, it would be great to have valid finality proofs though.

@xlc
Copy link
Member Author

xlc commented Mar 15, 2024

@serban300 can you give this a look and give it a try? #695
it is currently just return mock data (0x7777...). Let us know if that works or if anything adjustments are needed

@serban300
Copy link

@xlc Thank you ! Will give it a try next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants