Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't handle data part on error Status code query results #133

Open
lsulak opened this issue Aug 15, 2024 · 0 comments · May be fixed by #134
Open

Don't handle data part on error Status code query results #133

lsulak opened this issue Aug 15, 2024 · 0 comments · May be fixed by #134
Assignees
Labels
enhancement New feature or request

Comments

@lsulak
Copy link
Collaborator

lsulak commented Aug 15, 2024

Background

Error Status Code usually means that the data for such row is all NULL. In such case, a return type must be an Option and must be specified by a user. Ideally we should not burden our users with such cases and we should programmatically ensure that when the DB query returns error-like status codes / results, data is not taken into account at all.

There might be some Read related changes for Doobie, especially because we'll be introducing an Option return type for data. This might be a good read:

@lsulak lsulak added the enhancement New feature or request label Aug 15, 2024
@lsulak lsulak self-assigned this Aug 15, 2024
lsulak added a commit that referenced this issue Aug 15, 2024
@lsulak lsulak moved this from 🆕 To groom to 🔖 Sprint in CPS small repos project Aug 15, 2024
@lsulak lsulak moved this from 🔖 Sprint to 🏗 In progress in CPS small repos project Aug 15, 2024
@lsulak lsulak changed the title Error Status code means data can be null Don't handle data part on error Status code query results Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

1 participant