Feat/mod management #12
Conversation
Trico-Everfire
force-pushed
the
feat/mod_management
branch
from
3b63957 to
8e2abd5
Compare
|
The command line handler is a bug introduced in the last PR where it'd ignore " and ' in command line arguments, this fixes that :) |
CMakeLists.txt
Outdated
| @@ -11,7 +13,7 @@ endif() | |||
| if(UNIX) | |||
| set(CMAKE_CXX_STANDARD 20) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") | |||
| set(QT_INCLUDE "/usr/include/x86_64-linux-gnu/qt5") | |||
| set(QT_INCLUDE "$ENV{HOME}/Qt/6.4.1/gcc_64/include/") | |||
There was a problem hiding this comment.
This shouldn't be required anymore. CMake should figure it out.
There was a problem hiding this comment.
Wasn't it that this was required for people who don't have QT installed in the place CMake expects it to be? Like you said with the Chaos QT6 install repo?
|
Erin, I want to ask, I've made a window for adding the newly made mod to P2CE Hammer's config, should I add that into this PR or is it not required within the scope of this PR/Project? |
|
Add it into another PR. |
|
Will do after this PR, as it relies on this PR to function (provided it's part of the mod management) |
|
Hey... I was wondering, when will it'll be reviewed? I know you're busy with P2CE and other things, so no haste. |
|
I don't really have a time frame for when it will be reviewed other than when I have time. I have several projects taking up a bunch of my time, and I'm focused on getting on with them rather than my open-source projects. |
|
That's all right, I'll just await the next review. Thank you for your time. |
I added a zip extractor based using the minizip-ng library and some help from the internet. I integrated this into the SDK Launcher to allow the creation of P2CE Source mods.
This also upgrades the application from QT5 to QT6
string_builder and zip_handler are C code and are used in the zip extraction process. Feel free to tear the code apart.
Resolves #2