Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BOLT 12 invoice to payment flow #56

Open
sbddesign opened this issue Dec 13, 2024 · 1 comment
Open

Add BOLT 12 invoice to payment flow #56

sbddesign opened this issue Dec 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sbddesign
Copy link
Contributor

Currently, our payment flow supports BOLT 11 only. We should support BOLT 12 here. I think this is where it makes sense to actually use the BOLT 12 invoice lni... instead of an offer lno.... For any kind of order fulfillment system with bitcoin payments, you need to be able to distinguish one bitcoin payment from another. If we have tons of 5k sat payments all coming in to the same offer, we don't have a great way to correlate a payment with a given order. Thus, I think the BOLT 12 invoice would be a good solution here. But I'd love to hear others thoughts.

@sbddesign sbddesign added the enhancement New feature or request label Dec 13, 2024
@sbddesign
Copy link
Contributor Author

Notes from call:

  • Support paying to BOLT 11 and BOLT 12
  • Default to BOLT 11 for older wallets?
  • Shiny button to draw attention to the BOLT 12 invoice (mostly devs will be interested in this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant