Deprecate HyP3.check_quota in favor of HyP3.check_credits
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhkennedy
commented
Feb 2, 2024
src/hyp3_sdk/hyp3.py
Outdated
| @@ -487,10 +488,20 @@ def my_info(self) -> dict: | |||
| _raise_for_hyp3_status(response) | |||
| return response.json() | |||
|
|
|||
| def check_quota(self) -> Optional[int]: | |||
| def check_credits(self) -> Optional[float]: | |||
There was a problem hiding this comment.
Hmm, it looks like we only specify "number" in HyP3's OpenAPI spec, which could be a float or an int. I wonder if we should actually make this specify float or int, or always coarse to float. Right now, I suppose they will actually come as ints unless we make a job cost a fractional amount...
jhkennedy
force-pushed
the
deprecate-quota
branch
from
5795b70 to
43a2444
Compare
jhkennedy
force-pushed
the
deprecate-quota
branch
from
a57fbb5 to
f449ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
HyP3.check_creditsmethod to check your remaining creditsHyP3.check_quotaHyP3.check_quota's return type fromOptional[int]toOptional[float]