Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cfn-lint workflow #119

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix cfn-lint workflow #119

merged 2 commits into from
Jul 2, 2024

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented Jul 1, 2024 •
edited
Loading

The CloudFormation changes address these cfn-lint warnings:

E3045 A bucket with 'AccessControl' set should also have at least one 'OwnershipControl' configured
cloudformation.yml:7:5

W3045 'AccessControl' is a legacy property. Consider using 'AWS::S3::BucketPolicy' instead
cloudformation.yml:9:7

I just copy-pasted from https://github.com/ASFHyP3/hyp3/. Changes match what we released for ASFHyP3/hyp3-event-monitoring#79.

@jtherrmann jtherrmann marked this pull request as draft July 1, 2024 23:22
@jtherrmann jtherrmann marked this pull request as ready for review July 2, 2024 22:57
@asjohnston-asf asjohnston-asf self-requested a review July 2, 2024 23:08
@jtherrmann jtherrmann merged commit 1b2ffb6 into main Jul 2, 2024
1 check passed
@jtherrmann jtherrmann deleted the cfn-lint branch July 2, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asjohnston-asf asjohnston-asf asjohnston-asf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtherrmann @asjohnston-asf