Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Deprecate the webusb package dependency #110

Merged
merged 2 commits into from
May 25, 2024

Conversation

windowsair
Copy link
Contributor

The webusb feature is already included in the usb package. Let's deprecate the extra webusb package.

The webusb feature is already included in the usb package. Let's
deprecate the extra webusb package.
@thegecko
Copy link
Member

Sorry for the delay replying here. By adding a dependency on node-usb in the examples it stops it from working in a browser environment.
We need to ensure dapjs can be used in the web (it's original intent) as well as on the desktop with node-usb poly-filling webusb

Please comment if I've missed a point!

@windowsair
Copy link
Contributor Author

In the folder for each example there is a web.html, they should not depend on any other js file except dapjs, I'm not sure if this is what you want?

@thegecko
Copy link
Member

I'm keen web users don't assume they need to download node-usb to use the examples.

Perhaps a better approach would be to reorganise the examples into web ones and desktop ones?

@windowsair
Copy link
Contributor Author

I think it's better to update the documentation. Some of the content in the current documentation is no longer applicable.

@thegecko thegecko merged commit 24092bf into ARMmbed:master May 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants