Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

module: timer: add API to update timer status without alarm #794

Closed
wants to merge 17 commits into from
Closed

module: timer: add API to update timer status without alarm #794

wants to merge 17 commits into from

Conversation

Joe-Zhucg
Copy link
Contributor

Some device need interrupt to update internal status. Add new driver API to do this if there is no acitve alarm.

Change-Id: I6a3106beb8dce8de7de29dfa5ff5742a9fd9692b

@ssg-bot
Copy link

ssg-bot commented May 19, 2023

Can one of the admins verify this patch?

@nicola-mazzucato-arm
Copy link
Collaborator

Hi @Joe-Zhucg
if I understand correctly, you need to update the driver's internals every time there's an interrupt.
What I would like to understand better is how you use the timer feature without the alarm.
Can you please provide a bit more info?
How do you set and enable the timer driver if you don't make use of the alarms?

Thanks

@Joe-Zhucg
Copy link
Contributor Author

Correct, I want to use this API to update internal counter. My platform only has one 32 bits HW timer and it will timeout soon. Driver uses one 64 bits SW counter and this 32 bits timer counter register to simulate 64 bits timer. 64 bits SW counter will be updated in each timeout interrupt even it is not an alarm interrupt.
Timer starts at initialize function, count from 0 and initial timeout is 0xffffffff. With 24MHz timer clock input, it will timeout in 3 minutes.

@nicola-mazzucato-arm
Copy link
Collaborator

Will bring this PR over to gitlab where we will continue the conversation.
In principle LGTM, but I may ask minor renaming.
Thanks @Joe-Zhucg

@nicola-mazzucato-arm
Copy link
Collaborator

@Joe-Zhucg can you please login into the gitlab SCP-firmware repo so we can continue the conversation there?
Thanks

nicola-mazzucato-arm and others added 17 commits January 2, 2024 12:21
@nicola-mazzucato-arm
scmi: Shorten long error messages
d92b3ff 
Two log messages are over 80 chars and thus are truncated.

Shorten them without losing the sense.

Signed-off-by: Nicola Mazzucato <[email protected]>
Change-Id: I840c6de0c555f5e8a7f7a30104eda3af44f80c4e
@shriram-k-arm
module/cmn_cyprus: suppress release build warnings
b9b7aa9 
A couple of helper functions and variables in the CMN Cyprus driver are
used only in the Debug build. So, if the module is compiled in a Release
build, the compiler throws unused variable/function warnings. Hence, add
workaround to suppress the warning.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I99fcc836f3a039655880fb0b861e1e883a0de3bf
@shriram-k-arm
module/cmn_cyprus: fix incorrect format specifier for clang
82f04c2 
The Clang compiler considers uint32_t data type as 'unsigned int'
whereas the GCC considers it as 'long unsigned int'. A potential
solution is to use PRIx format specifiers provided in the inttypes
header but it is not compatible with aarch64 host machines.

Hence, as a workaround, cast the uint32_t variables as unsigned int data
type when printing as the concerned variables are guaranteed to be under
16 bits.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I548f2709e2dfe460c176455b02982b33d1a2041e
@shriram-k-arm
rdfremont: add sid module config data for scp_ramfw
843f2f0 
The SID peripheral provides information about the platform and its
configuration. So, add the configuration data for sid module in scp
ramfw. The configuration data includes the expected value of its
PID/CID registers for identification. PID5, PID6 and PID7 are not
implemented by this peripheral and this is indicated using the valid
register bitmap.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I9ce8ad9eff33dedf32a6129fc5181871fe595fc3
@shriram-k-arm
rdfremont: add system info module config data for scp_ramfw
90da07c 
System Info module provides API to obtain platform configuration data in
a platform independent manner. So, add configuration data for system
info module in scp ramfw. The configuration data specifies the PID
module as the driver to obtain the platform configuration data.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I5de1b605ec66057709ea407865958504b9410562
@shriram-k-arm
rdfremont: add pl011 module config data for scp_ramfw
c1beb21 
PL011 controller is used as a console port for debug and log messages.
Add config data of this controller in scp ramfw, including base address
and input clock frequency for the PL011 module to use.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I96ba337a98de643b1be6b998da05023308ac91e5
@shriram-k-arm
rdfremont: configure I/O stream for scp_ramfw
d7fcf08 
Configure the macros FMW_IO_STDIN_ID and FWM_IO_STDOUT_ID exposed by the
I/O framework to set the SCP UART as the system entity responsible for
handling I/O for the scp firmware.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I79424c10a61d2e12b8d1336cf4239f54d11b4c97
@shriram-k-arm
rdfremont: add MPU module config data for scp_ramfw
e6b12ca 
Add config data for armv7m_mpu module in scp ramfw. The SCP RAMs,
trusted RAM and non-trusted memory regions are specified.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I4b0ac74a322f997894a6f9140ebce5ba4a62600d
@shriram-k-arm
rdfremont: add SCP power control block register declaration
1df315d 
SCP's power control block includes registers for various system
configuration and status. Add the register space declaration for this
block.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I29cf403afa0b36b17f0a5e171e66a37a2ddf14b1
@shriram-k-arm
rdfremont: add core manager register block declaration
3e325b9 
Core Manager block includes registers for configuration and clock
control for application cores and the associated clusters. Add the
register space declaration and the base address macro for the core
manager block.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I14c91e97947b70dd6c2e3fa885e9b9ef00a0713d
@shriram-k-arm
rdfremont: add System PIK register space declaration
f43b715 
System Power Integration Kit (PIK) control register block includes
registers for clock control of clocks in SYSTOP power domain. Add
the register space declaration for System PIK.

Signed-off-by: Shriram K <[email protected]>
Change-Id: Ib6623d872b956923f0d604f33d0c710a9e702fc5
@shriram-k-arm
rdfremont: add config data for system pll driver in scp_ramfw
522e4f5 
PLLs are connected to the SCP's expansion3 memory region. Add the
configuration data for the module 'system_pll' that will manage and
setup these PLLs to required frequency. The configuration data includes
the SYSTOP PLL and the interconnect PLL.

Signed-off-by: Shriram K <[email protected]>
Change-Id: Ia1d80d8631f7200069745130ee92f031008f58bb
@shriram-k-arm
rdfremont: add config data for PIK clock driver in scp_ramfw
d762551 
The configuration data for PIK clock devices includes register address
of its control and dividers, the rate table and the initial rate. The
clock controller devices for all the CPUs, interconnect, systop, gic,
scp, uart and other clocks are included in the configuration data.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I5c41e4bfe379f41bf90fb6bcaf2e0f32bab535a1
@shriram-k-arm
rdfremont: add config data for subsystem clock driver in scp_ramfw
ce8e70f 
The application core clocks is configured by the css clock driver. Add
the configuration data for this driver that includes the rate table,
initial rate and PLL driving each of the css clocks.

Signed-off-by: Shriram K <[email protected]>
Change-Id: I8d91329d2e41e020856002c619c735771062a105
@shriram-k-arm
rdfremont: add helpers to obtain platform topology in scp_ramfw
caa5b48 
Add functions to obtain the platform topology information such as core
count and cluster count. These functions can be used in module config
data to obtain platform topology.

Signed-off-by: Shriram K <[email protected]>
Change-Id: Ice0495d8f1dbb3541f3b3c47e0ab0bb756dffbd7
@shriram-k-arm
rdfremont: add config data for power domain module in scp_ramfw
a39e8ab 
Provide the configuration data of all the available power domains to
the power domain HAL. The configuration data includes details of all the
supported CPU, cluster and the SYSTOP power domain.

Signed-off-by: Shriram K <[email protected]>
Change-Id: If4a67cf0559668712fadc2d863e9a06feb569fbb
@Joe-Zhucg
module: timer: add API to update timer status without alarm
f29ae1c 
Some devices need overflow interrupt to update internal status. Add new
driver API to handle this if there is no acitve alarm.

Change-Id: I6a3106beb8dce8de7de29dfa5ff5742a9fd9692b
Signed-off-by: Joe Zhu <[email protected]>
@github-actions GitHub Actions
Copy link

Hello! 👋

Thank you for your contribution to the SCP-firmware Project!

SCP-firmware contributions can only be submitted through GitLab. This GitHub repo is accessible as a Read-Only mirror and it is not able to accept contributions for the project.

How do I contribute patches to SCP-firmware?

Please raise a Merge Request in SCP-firmware GitLab.

What if I face any problems?

You may use GitLab's Issues to post any questions or problems you might have.

We look forward to seeing your patches submitted to SCP-firmware GitLab!

The SCP-firmware team

@nicola-mazzucato-arm
Copy link
Collaborator

@Joe-Zhucg can you please submit the new set in gitlab? thanks

@leandro-arm
Copy link
Collaborator

Hello! 👋

Thank you for your contribution to the SCP-firmware Project!

SCP-firmware contributions can only be submitted through GitLab. This GitHub repo is accessible as a Read-Only mirror and it is not able to accept contributions for the project.

This PR has been migrated to: https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/794

The SCP-firmware team

@leandro-arm leandro-arm closed this Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicola-mazzucato-arm nicola-mazzucato-arm Awaiting requested review from nicola-mazzucato-arm

@souvikkc souvikkc Awaiting requested review from souvikkc

@tarek-arm tarek-arm Awaiting requested review from tarek-arm tarek-arm is a code owner

@girishpathak girishpathak Awaiting requested review from girishpathak girishpathak is a code owner

@leandro-arm leandro-arm Awaiting requested review from leandro-arm leandro-arm is a code owner

@AhmedImbabyGadallah AhmedImbabyGadallah Awaiting requested review from AhmedImbabyGadallah AhmedImbabyGadallah is a code owner

@mohamedasaker-arm mohamedasaker-arm Awaiting requested review from mohamedasaker-arm mohamedasaker-arm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joe-Zhucg @ssg-bot @nicola-mazzucato-arm @leandro-arm @shriram-k-arm