More dashboard report work

APTrust · Nov 28, 2023 · 7a6afaa · 7a6afaa
1 parent e9288b8
commit 7a6afaa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/core/aptrust_client_v3.go b/core/aptrust_client_v3.go
@@ -186,6 +186,8 @@ func (client *APTrustClientV3) connect() error {
 	return err
 }
 
+// We check this because we don't want our depositors accidentally sending
+// their API credentials to just anyone.
 func (client *APTrustClientV3) isValidDomain() bool {
 	parsedUrl, err := url.Parse(client.config.Url)
 	if err != nil {

diff --git a/core/remote_repository.go b/core/remote_repository.go
@@ -164,7 +164,7 @@ func (repo *RemoteRepository) TestConnection() error {
 // from this remote repository.
 func (repo *RemoteRepository) ReportsAvailable() ([]util.NameValuePair, error) {
 	reports := make([]util.NameValuePair, 0)
-	if util.LooksLikeUUID(repo.PluginID) {
+	if !util.LooksLikeUUID(repo.PluginID) {
 		return reports, fmt.Errorf("no client exists for this repo because plugin id is not a uuid")
 	}
 	client, err := GetRemoteRepoClient(repo)

diff --git a/server/controllers/dashboard_controller.go b/server/controllers/dashboard_controller.go
@@ -38,9 +38,9 @@ func DashboardShow(c *gin.Context) {
 	}
 
 	data := gin.H{
-		"jobs":       result.Jobs,
-		"reports":    string(reportListJson),
-		"reportsErr": err,
+		"jobs":           result.Jobs,
+		"reportListJson": string(reportListJson),
+		"reportsErr":     err,
 	}
 
 	c.HTML(http.StatusOK, "dashboard/show.html", data)

diff --git a/server/views/dashboard/show.html b/server/views/dashboard/show.html
@@ -38,8 +38,8 @@
 
 <script>
 $(function(){
-  var repoReports = `{{ .reportListJson }}`
-  
+  var reports = {{ .reportListJson }}
+
 })
 </script>