Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules shall enforce things #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xbonnetain
Copy link

Rule 5 is currently written as a suggestion:

The tool rustfmt can be used to ensure...

This is the only rule written this way, and it defeats its purpose.

This PR changes "can" to "must".

Other approaches

There are other possibilities, for example:

  • Removing this rule
  • Adding a "Suggestion/Best practice" block for non-mandatory things

@danielhenrymantilla
Copy link
Contributor

Forcing the usage of a specific formatter feels contrived, though. Maybe "an autoformatting tool (e.g. rustfmt) must be used". This way the phrasing remains open to alternative formatters that may arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants