Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to cap the timestep that VODE tries #639

Closed
zingale opened this issue Apr 3, 2021 · 2 comments
Closed

we need to cap the timestep that VODE tries #639

zingale opened this issue Apr 3, 2021 · 2 comments

Comments

@zingale
Copy link
Member

zingale commented Apr 3, 2021

VODE seems to want to try a timestep 3 or more orders of magnitude larger than the tmax we want to burn with. For simplified-SDC, this means that the advective term essentially evacuates a cell, leaving the density negative (or small_dens), which causes thermodynamic problems down the road.

We should cap the timestep at tmax / 2 or so. @jmsexton03 knows a bit about this.

This will help with:
AMReX-Astro/Castro#1596

@zingale
Copy link
Member Author

zingale commented Apr 3, 2021

oh, so it looks like we actually want what was itask = 4 in the original VODE (which we've since ripped out):

C          4  means normal computation of output values of y(t) at                                                                                                                              
 429 C             t = TOUT but without overshooting t = TCRIT.                                                                                                                                      
 430 C             TCRIT must be input as RWORK(1).  TCRIT may be equal to                                                                                                                           
 431 C             or beyond TOUT, but not behind it in the direction of                                                                                                                             
 432 C             integration.  This option is useful if the problem                                                                                                                                
 433 C             has a singularity at or beyond t = TCRIT.                               

@zingale
Copy link
Member Author

zingale commented Apr 6, 2021

turns out the issue was due to #643

It might be interesting to explore this in the future, but it is no longer critical

@zingale zingale closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant