Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address timestep and cfl violation for Spherical2D #2962

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

zhichen3
Copy link
Collaborator

PR summary

address #2927 . Change timestep and cfl_violation so we use rdtheta, rdx[1], which is the physical cell length instead of just dx[1] for cell length in theta direction for spherical 2d.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Sep 19, 2024

we might need to change things in radiation, especially since dx.array is passed on to estimate_gamrPr. I could just change it to rdtheta, but I don't really know if its the right thing to do. It's probably only supported for cartesian?

@zingale zingale mentioned this pull request Sep 19, 2024
14 tasks
@zhichen3 zhichen3 marked this pull request as ready for review September 19, 2024 15:38
@zingale zingale merged commit fb34ee1 into AMReX-Astro:development Sep 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants