Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit the transverse update #1853

Open
zingale opened this issue Jun 1, 2021 · 3 comments
Open

revisit the transverse update #1853

zingale opened this issue Jun 1, 2021 · 3 comments
Labels

Comments

@zingale
Copy link
Member

zingale commented Jun 1, 2021

Right now, we do the transverse correction to the conserved state + p. This way we don't need to use the EOS to get p on the interface when we go back to the primitive state for the Riemann solve.

But the EOS is pretty cheap now (with the templating), that it might be cleaner and more robust to update the conserved system, derive (rho e) after the correction and handle it in the same dual energy fashion as we do elsewhere, and then use ctoprim to get the new corrected primitive edge state.

@zingale
Copy link
Member Author

zingale commented Jun 1, 2021

I think that this would actually match what we do with MHD

@zingale
Copy link
Member Author

zingale commented Jun 25, 2021

this is implemented in #1920

@zingale zingale added the hydro label Sep 9, 2021
@zingale
Copy link
Member Author

zingale commented Apr 23, 2022

note that the bug fix on the reset species with density was done separately now in #2120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant