You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we do the transverse correction to the conserved state + p. This way we don't need to use the EOS to get p on the interface when we go back to the primitive state for the Riemann solve.
But the EOS is pretty cheap now (with the templating), that it might be cleaner and more robust to update the conserved system, derive (rho e) after the correction and handle it in the same dual energy fashion as we do elsewhere, and then use ctoprim to get the new corrected primitive edge state.
The text was updated successfully, but these errors were encountered:
Right now, we do the transverse correction to the conserved state + p. This way we don't need to use the EOS to get p on the interface when we go back to the primitive state for the Riemann solve.
But the EOS is pretty cheap now (with the templating), that it might be cleaner and more robust to update the conserved system, derive (rho e) after the correction and handle it in the same dual energy fashion as we do elsewhere, and then use ctoprim to get the new corrected primitive edge state.
The text was updated successfully, but these errors were encountered: