Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovmf build fails on Ubuntu 20.04 #3

Open
nicopal opened this issue Mar 28, 2022 · 2 comments
Open

ovmf build fails on Ubuntu 20.04 #3

nicopal opened this issue Mar 28, 2022 · 2 comments

Comments

@nicopal
Copy link

nicopal commented Mar 28, 2022

Hi,

when running the command

nice build -v --cmd-len=64436 -DDEBUG_ON_SERIAL_PORT=TRUE -n 32 -t GCC5 -a X64 -p OvmfPkg/OvmfPkgX64.dsc

I get the following error:

[OUTPUT SKIPPED]

Building ... /home/host/AMDSEV/ovmf/OvmfPkg/Library/BlobVerifierLibNull/BlobVerifierLibNull.inf [X64]
make: Nothing to be done for 'tbuild'.
Building ... /home/host/AMDSEV/ovmf/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf [X64]
"nasm" -I/home/host/AMDSEV/ovmf/MdePkg/Library/BaseLib/X64/ -I/home/host/AMDSEV/ovmf/MdePkg/Library/BaseLib/X64/ -I/home/host/AMDSEV/ovmf/MdePkg/Library/BaseLib/ -I/home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib/DEBUG/ -I/home/host/AMDSEV/ovmf/MdePkg/ -I/home/host/AMDSEV/ovmf/MdePkg/Include/ -I/home/host/AMDSEV/ovmf/MdePkg/Test/UnitTest/Include/ -I/home/host/AMDSEV/ovmf/MdePkg/Include/X64/ -f elf64 -o /home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib/OUTPUT/X64/LongJump.obj /home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib/OUTPUT/X64/LongJump.iii
/home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib/OUTPUT/X64/LongJump.iii:44: error: parser: instruction expected
/home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib/OUTPUT/X64/LongJump.iii:49: error: parser: instruction expected
make: *** [GNUmakefile:782: /home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib/OUTPUT/X64/LongJump.obj] Error 1

build.py...
: error 7000: Failed to execute command
make tbuild [/home/host/AMDSEV/ovmf/Build/OvmfX64/DEBUG_GCC5/X64/MdePkg/Library/BaseLib/BaseLib]

build.py...
: error F002: Failed to build module
/home/host/AMDSEV/ovmf/MdePkg/Library/BaseLib/BaseLib.inf [X64, GCC5, DEBUG]

Any clues what might cause this?
@tlendacky
Copy link
Collaborator

EDK2 has recently changed the minimum required NASM level. See https://edk2.groups.io/g/devel/topic/89637409#87359

You will need to install 2.15.05 in order to build on Ubuntu 20.04.

@nicopal
Copy link
Author

nicopal commented Mar 28, 2022

Thank you, that solved the issue.

mdroth pushed a commit that referenced this issue Mar 29, 2024
@Flickdm @mergify
NetworkPkg: Ip6Dxe: SECURITY PATCH CVE-2023-45231 Patch
bbfee34 
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4536

Bug Overview:
PixieFail Bug #3
CVE-2023-45231
CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
CWE-125 Out-of-bounds Read

Out-of-bounds read when handling a ND Redirect message with truncated
options

Change Overview:

Adds a check to prevent truncated options from being parsed
+  //
+  // Cannot process truncated options.
+  // Cannot process options with a length of 0 as there is no Type
field.
+  //
+  if (OptionLen < sizeof (IP6_OPTION_HEADER)) {
+    return FALSE;
+  }

Cc: Saloni Kasbekar <[email protected]>
Cc: Zachary Clark-williams <[email protected]>

Signed-off-by: Doug Flick [MSFT] <[email protected]>
Reviewed-by: Saloni Kasbekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicopal @tlendacky