Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sprites aren't affected by palette swaps. #72

Open
Miepee opened this issue Feb 28, 2021 · 3 comments
Open

Some sprites aren't affected by palette swaps. #72

Miepee opened this issue Feb 28, 2021 · 3 comments
Labels
bug Something isn't working the way it should

Comments

@Miepee
Copy link
Contributor

Miepee commented Feb 28, 2021

Describe the Feature request you'd like
Currently, the palettes don't change the missile selected part of the gun. It seems that these are hardcoded.
I'd like to change these with a palette. It would look really weird if my custom gun would be blue, but the sprite still showed green for the tip.

Media
grafik
grafik

@Miepee Miepee added the enhancement Change to or improvement of existing behavior label Feb 28, 2021
@Lojemiru Lojemiru added bug Something isn't working the way it should and removed enhancement Change to or improvement of existing behavior labels Mar 2, 2021
@Lojemiru
Copy link
Collaborator

Lojemiru commented Mar 2, 2021

Thought we fixed this a while back - sprites must have been jumbled again in the "1.4.4" merge between 1.4.3 and 1.5. Re-labeling as they're supposed to be recolored.

@Miepee
Copy link
Contributor Author

Miepee commented Mar 2, 2021

Another thing that may or may not be related to this:
Screw attack doesn't seem to respect the palette change as well
grafik
For reference, this is how my palette looked like (it's supposed to make samus completely invisible):
power

@Miepee
Copy link
Contributor Author

Miepee commented Mar 2, 2021

And on another note:
There is one(!) pixel in the left running animation (not the right, and not in the walking animation) that's also not affected by palette changes.
snap 0015

@Miepee Miepee changed the title Make the "missile-selected" sprite be affected by palette swaps as well. Some sprites aren't affected by palette swaps. Mar 2, 2021
@Miepee Miepee added this to the 1.5.4 Bugfixes milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way it should
Projects
None yet
Development

No branches or pull requests

2 participants