Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification on Qemu.set_hook vs QEMUHooks #2145

Open
vringar opened this issue May 4, 2024 · 0 comments
Open

Clarification on Qemu.set_hook vs QEMUHooks #2145

vringar opened this issue May 4, 2024 · 0 comments

Comments

@vringar
Copy link
Contributor

vringar commented May 4, 2024

Hey,
questions regarding QemuHooks.instruction

  1. Was it an accident that the instruction_function and instruction_closure functions were made public as well?
  2. Should there be a deprecation notice/hint on Qemu.set_hook to encourage people to migrate to the new API?

I'm happy to submit PRs for both of these, I just wanted to make sure I fully understood the context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vringar