Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced translator error messages. #297

Closed
charles-turner-1 opened this issue Dec 10, 2024 · 5 comments
Closed

Enhanced translator error messages. #297

charles-turner-1 opened this issue Dec 10, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@charles-turner-1
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

#279 and #290 : when builds fail due to translator errors, it can be difficult to reliably identify which translator failed. This can be an issue at catalog build time if NCI datastores change.

Describe the feature you'd like

Translators to provide a class name when failing such that debugging translator failures is more straightforward.

Describe alternatives you've considered

<Replace this text with a clear and concise description of any alternative solutions or features you've considered.>

Additional context

@charles-turner-1
Copy link
Collaborator Author

@marc-white I'm wrapping up the translator errors now - PR should be in ASAP.

@marc-white
Copy link
Collaborator

Once that's in, for speed I won't bother with a new draft release - I'll just do a local install of the updated main and run a build from that.

@marc-white
Copy link
Collaborator

@charles-turner-1 how are you traveling? Can I help at all?

@charles-turner-1
Copy link
Collaborator Author

charles-turner-1 commented Dec 10, 2024

See #298 - got hung up trying to move all the error handling into a single decorator - struggling to get it to grab func.__name__ correctly.

@charles-turner-1
Copy link
Collaborator Author

Closed by #298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants