Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidation on use of pathlib module for filesystem operations, rather than pathlib & os.path #271

Open
charles-turner-1 opened this issue Nov 26, 2024 · 1 comment · May be fixed by #306
Open

Consolidation on use of pathlib module for filesystem operations, rather than pathlib & os.path #271

charles-turner-1 opened this issue Nov 26, 2024 · 1 comment · May be fixed by #306
Assignees
@marc-white
Labels
enhancement New feature or request

Comments

@charles-turner-1
Copy link
Collaborator

Currently, this package uses both pathlib.Path operations & os.path.join in a lot of places, with usage of both in plenty of files.

Pathlib has been the preferred way of doing things since Python 3.4 , and so we should think about moving over to using pathlib where possible.

Low priority.
@charles-turner-1 charles-turner-1 added the enhancement New feature or request label Nov 26, 2024
@marc-white
Copy link
Collaborator

Also noting that a lot of functions either quietly expect a directory string, or a Path object, but will fail if the other is given. This should be consolidated to be a Path object everywhere.

@charles-turner-1 charles-turner-1 mentioned this issue Dec 4, 2024
Merged
charles-turner-1 added a commit that referenced this issue Dec 10, 2024
@charles-turner-1 @marc-white @pre-commit-ci
257 replace mocks (#291)
44ad1bf 
* Removed lots of mocks from tests where not needed.

* Replaced lots of call to os module with pathlib (#271)


Co-authored-by: Marc White <[email protected]>

---------

Co-authored-by: Marc White <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@marc-white marc-white self-assigned this Dec 11, 2024
@marc-white marc-white linked a pull request Dec 11, 2024 that will close this issue
Consolidate on pathlib module #306
Draft
@marc-white marc-white linked a pull request Dec 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-white marc-white

Labels
enhancement New feature or request
Projects
Model Evaluation & Diagnostics
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate on pathlib module ACCESS-NRI/access-nri-intake-catalog
2 participants
@marc-white @charles-turner-1