-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata with frame_id
, version
and temporal_baseline_days
#102
Merged
Merged
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6a72fce
update metadata w/ frame_id and secondary dt
cmarshak 9b68415
update changelog; fix version num
cmarshak 70ccb38
add frame-id to test data
cmarshak 07ddf91
Update delivery_prep.py
cmarshak 5a4617b
temporal baseline and frame id
cmarshak add751c
Merge branch 'dev' into frame-metadata
cmarshak dff9012
Merge branch 'fix_variable_name_error' into frame-metadata
cmarshak f28b198
fix datetime types
cmarshak 8bf78a7
remove duplicate SET line
cmarshak 772abf2
merge dev
cmarshak 257c7b8
ensure start time is earliest
cmarshak 6e1cc3b
split url and download cells
cmarshak 47a52d7
ensure midnight crossing is correctly handled per DB
cmarshak a989999
Merge branch 'dev' into frame-metadata
cmarshak 7c72c95
increase dataset version 3.0.0, include version in cmr metadata, and …
cmarshak cf387a7
dynamically update dataset version for test
cmarshak fd73e06
lint
cmarshak 4b8019a
andrews suggestion
cmarshak 7ccb526
revert localized data
cmarshak 65f6c9d
Merge branch 'dev' into frame-metadata
cmarshak 98dadaf
Update __main__.py with water mask
cmarshak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing some context for @dbekaert important comments about obtaining an accurate temporal baseline in days. We expect this temporal baseline in days to be a multiple of 6 based on S1's repeat pass frequency.
Suppose the temporal baseline (in days) is for example 5.999999. If
delta
is adatetime.timedelta
object, thendelta.days
will be 5 (not 6). Therefore, we want to do the rounding usingtotal_seconds()
. This resolves David's concerns.Here is an example:
Will be
5
.To be clear, this concern can occur anywhere and anytime, not just at pairs in which acquisitions are close to midnight in UTC.