Merge branch 'dev' into resource-competition

CHANGELOG.md

@@ -14,11 +14,15 @@ and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ### Fixed
 * For Solid Earth Tide computation, derive coordinates and spacing from geotrans as opposed to latitude/longitude metadata arrays
-* Include topsapp_iono template.
+* Include topsapp_iono template. 
 * Increases DEM buffer to .4 from .1 to ensure the extent of at least two bursts (~40 km) are added when retrieving DEM (because estimated footprint can differ from what ISCE2 generates for a GUNW extent)
+* Catch warnings in tests and match messages to ensure package warnings do not fail test suite
+* Read low resolution Natural Earth land masses from public url due to removal from geopandas package.
+* For ionosphere computation over water, includes masking conncomp zero, phase bridging, and modified adaptive gaussian filtering
 
 ### Added
 * localize_data within __main__.py added option to use/not use water mask for ionosphere processing
+* Added option to estimate burst phase jumps in ionosphere computation
 
 ## [0.2.3]
 

isce2_topsapp/__main__.py

@@ -178,6 +178,10 @@ def gunw_slc():
     json.dump(loc_data, open("loc_data.json", "w"),
               indent=2, cls=MetadataEncoder)
 
+    # Turn-off ESD when using ionospheric computation
+    if args.estimate_ionosphere_delay:
+        args.esd_coherence_threshold = -1
+
     topsapp_processing(
         reference_slc_zips=loc_data["ref_paths"],
         secondary_slc_zips=loc_data["sec_paths"],
@@ -193,15 +197,16 @@ def gunw_slc():
     )
 
     # Run ionospheric correction
+    # MG: correct burst jumps, e.g. needed for Arabian
+    #   processing. TODO: We need a trigger function for
+    #   this option (it adds almost double time to iono)
+    #   example: look at filt_toposphase.unw or .flat
+    #   and analyze if there are any burst jumps,
+    #   if yes, set this option True
     if args.estimate_ionosphere_delay:
         iono_processing(
-            reference_slc_zips=loc_data["ref_paths"],
-            secondary_slc_zips=loc_data["sec_paths"],
-            orbit_directory=loc_data["orbit_directory"],
-            extent=loc_data["processing_extent"],
-            dem_for_proc=loc_data["full_res_dem_path"],
-            dem_for_geoc=loc_data["low_res_dem_path"],
             mask_filename=loc_data["water_mask"],
+            correct_burst_jumps=False,
         )
 
     ref_properties = loc_data["reference_properties"]