From da5af3d47a5f7697fc1d9854d9da3a4bb004a7b1 Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 11:54:25 -0700 Subject: [PATCH 1/8] remove environment.yml --- environment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/environment.yml b/environment.yml index bc84a79..a546ff4 100644 --- a/environment.yml +++ b/environment.yml @@ -4,7 +4,7 @@ channels: - anaconda - defaults dependencies: - - python>=3.8,<3.10 + - python==3.9 - pip - affine - asf_search>=5.0.0 From eeda2d2888ab0d32b340eb9d1ab6f21534f0f873 Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 11:58:25 -0700 Subject: [PATCH 2/8] changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index af3a27b..6d13c58 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,11 @@ and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ### Added +## [0.2.3] + +## Removed +* Python 3.8 Support + ## [0.2.2] ### Added From 3e497c87f9d5cf81cc913b49adf85bc15e63dd4b Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 11:59:23 -0700 Subject: [PATCH 3/8] remove 38 from matrix --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a07fc33..8bf813f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: ["3.8", "3.9"] + python-version: ["3.9"] steps: - uses: actions/checkout@v2 From a3b57948f100af2f8d24b9d9e845ed48952d95d2 Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 12:17:27 -0700 Subject: [PATCH 4/8] bound rioxarray --- environment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/environment.yml b/environment.yml index a546ff4..10f4776 100644 --- a/environment.yml +++ b/environment.yml @@ -35,7 +35,7 @@ dependencies: - pytest-cov - pytest-mock - rasterio - - rioxarray + - rioxarray<=0.14.0 - xarray - scipy<1.10 - setuptools From 6c23f925ed51f4d052a734b01e5e352591531692 Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 13:54:30 -0700 Subject: [PATCH 5/8] remove bounds and duplicate scipy --- environment.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/environment.yml b/environment.yml index 10f4776..d6195ac 100644 --- a/environment.yml +++ b/environment.yml @@ -1,10 +1,8 @@ name: topsapp_env channels: - conda-forge - - anaconda - - defaults dependencies: - - python==3.9 + - python=>3.9,<3.10 - pip - affine - asf_search>=5.0.0 @@ -27,7 +25,7 @@ dependencies: - matplotlib - netcdf4 - notebook - - numpy<1.24 + - numpy - pandas - pysolid - papermill @@ -35,12 +33,11 @@ dependencies: - pytest-cov - pytest-mock - rasterio - - rioxarray<=0.14.0 + - rioxarray - xarray - - scipy<1.10 + - scipy - setuptools - setuptools_scm - - scipy<1.10 - shapely - tqdm - dem_stitcher>=2.4.0 From 1232e9cc0c2a64ac872aa18613070e50cc42c9c6 Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 15:17:35 -0700 Subject: [PATCH 6/8] instructions for finding build errors --- README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/README.md b/README.md index bd24ddf..54b19e9 100644 --- a/README.md +++ b/README.md @@ -144,6 +144,16 @@ docker run -ti -v $PWD:/home/ops/topsapp_data topsapp_img \ ``` where the `username`/`password` are the Earthdata credentials for accessing NASA data. We note the command line magic of the above is taken care of the `isce2_topsapp/etc/entrypoint.sh` (written by Joe Kennedy) which automatically runs certain bash commands on startup of the container, i.e. the run commands also calls the `isce2_topsapp` command line function as can be seen [here](isce2_topsapp/etc/entrypoint.sh). +# Build Issues + +ISCE2, gdal, and xarray are hard to balance. Ideally, we would have a dependabot to increment packages and integration tests to make sure datasets are generated correctly with each update. Unfortunately, this is not currently the case. So, we are including some snippets (credit to Joseph Kennedy) for determining where packages might fail. We have some caps in our environment.yml file. This is how we find them. Sometimes even with our rather minimal integration tests and builds, in 24 hours, a new package can entirely throw something awry with respect to builds. + +The easiest way to see what was the *last* working build, check out the docker [images](https://github.com/ACCESS-Cloud-Based-InSAR/DockerizedTopsApp/pkgs/container/dockerizedtopsapp) for the last build. `latest` refers to the latest production build on `main`. `test` refers to the last build on `dev`. But each merge to `dev` gets an image that is recorded. + +1. Click one of the images and it will tell you how to download an image into docker e.g. `docker pull ghcr.io/access-cloud-based-insar/dockerizedtopsapp:0.2.2.dev148_gab75888`. +2. Load the image and get into interactive mode e.g. `docker run --entrypoint /usr/bin/bash -it --rm ghcr.io/access-cloud-based-insar/dockerizedtopsapp:0.2.2.dev136_ga2d5389 -l` +3. Check the packages `conda list | grep xarray` + ## FAQ 1. The docker build is taking a long time. From 491fdca8e4f37f1bbcb9a0212397553067341fef Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 15:17:55 -0700 Subject: [PATCH 7/8] cap rioxarray and revert back to all caps --- environment.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/environment.yml b/environment.yml index d6195ac..a0f663f 100644 --- a/environment.yml +++ b/environment.yml @@ -25,7 +25,7 @@ dependencies: - matplotlib - netcdf4 - notebook - - numpy + - numpy<1.24 - pandas - pysolid - papermill @@ -33,9 +33,9 @@ dependencies: - pytest-cov - pytest-mock - rasterio - - rioxarray + - rioxarray<0.14.0 - xarray - - scipy + - scipy<1.10 - setuptools - setuptools_scm - shapely From cdd6a12a99568327938f49de091a3fdb41362176 Mon Sep 17 00:00:00 2001 From: cmarshak Date: Tue, 21 Mar 2023 15:23:21 -0700 Subject: [PATCH 8/8] fix cap syntax --- environment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/environment.yml b/environment.yml index a0f663f..62b1096 100644 --- a/environment.yml +++ b/environment.yml @@ -2,7 +2,7 @@ name: topsapp_env channels: - conda-forge dependencies: - - python=>3.9,<3.10 + - python>=3.9,<3.10 - pip - affine - asf_search>=5.0.0