Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrobox-assemble clone option #1617

Open
PawsFunctions opened this issue Nov 20, 2024 · 1 comment · May be fixed by #1618
Open

distrobox-assemble clone option #1617

PawsFunctions opened this issue Nov 20, 2024 · 1 comment · May be fixed by #1618
Labels
enhancement New feature or request

Comments

@PawsFunctions
Copy link

Is your feature request related to a problem? Please describe.
Currently, I am unable to clone an existing Distrobox when using the distrobox-assemble tool. While distrobox-assemble is useful for creating multiple Distroboxes, it does not allow cloning of an existing Distrobox in the same way the create command does.

Describe the solution you'd like
I would like the ability to clone an existing Distrobox when using the distrobox-assemble command. Specifically, the clone option should be passed to the create command, similar to the behavior of the create command by itself.

Describe alternatives you've considered
At this time, I have not found an alternative method to clone a Distrobox with the distrobox-assemble tool.

Additional context
It would be helpful to add a --clone flag to the distrobox-assemble command to support this feature. For reference, here is the distrobox-assemble image section in the code.

@PawsFunctions PawsFunctions added the enhancement New feature or request label Nov 20, 2024
@PawsFunctions
Copy link
Author

PawsFunctions commented Nov 20, 2024

I was able to implement cloning with a few small additions to distrobox-assemble, and it worked as expected.

The changes are in this section of the code:


image=""

on lines 49 and 275 (276):

clone=""

if [ -n "${image}" ]; then
result_command="${result_command} --image $(sanitize_variable "${image}")"
fi

and on line 345 (347):

	if [ -n "${clone}" ]; then
		result_command="${result_command} --clone $(sanitize_variable "${clone}")"
	fi

@PawsFunctions PawsFunctions linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant