fix: update spec generation to align with reality #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecshreve
changed the title
ecshreve
force-pushed
the
ecs/oapi-schema-gen
branch
2 times, most recently
from
75cbb18 to
f5f5962
Compare
ecshreve
force-pushed
the
ecs/oapi-schema-gen
branch
from
f5f5962 to
c706a11
Compare
ecshreve
commented
Dec 4, 2024
| @@ -201,7 +201,7 @@ class-spells-path: | |||
| content: | |||
| application/json: | |||
| schema: | |||
| $ref: '../schemas/combined.yml#/APIReferenceList' | |||
There was a problem hiding this comment.
fwiw, in a versioned world i would totally look at reworking the actual endpoint implementation for all of these to return a more uniform shape for "spells with a level". but if feels more important to have the docs match the actual response first.
bagelbits
approved these changes
Dec 4, 2024
|
🎉 This PR is included in version 3.10.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
How was it tested?
Is there a Github issue this is resolving?
#619
#358
#352 (was fixed awhile ago, but should definitely be good to close this issue now)
Was any impacted documentation updated to reflect this change?
This is docs, sort of
Here's a fun image for your troubles