Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce instance-base to avoid having PROD instances inherit from instance0 (maintenance) #138

Open
lukasgraf opened this issue Nov 26, 2018 · 1 comment
Assignees

Comments

@lukasgraf
Copy link
Contributor

lukasgraf commented Nov 26, 2018

We want to introduce something like an [instance-base] part that acts as an "abstract base class" for defaults that are common to both production (1-4) and maintenance (0) instances.

This is needed because we want to be able to add maintenance-instance-specific settings to instance0 (like, no warmup, stop trying to connect to ZEO after x seconds and exit) without running the risk of these settings falling through to production instances.

This would allow us to solve #59 cleanly.

Once we perform this change, we need to:

  • Identify all buildout configurations from all our repositories
  • Check each of these buildouts for custom [instance0] modifications
  • Rewrite all those [instance0] modifications to [instance-base]
@jone
Copy link
Member

jone commented Nov 26, 2018

👍 sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants