Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a chord picker #8

Open
4 of 11 tasks
4lejandrito opened this issue Jul 31, 2020 · 1 comment
Open
4 of 11 tasks

Add a chord picker #8

4lejandrito opened this issue Jul 31, 2020 · 1 comment

Comments

@4lejandrito
Copy link
Owner

4lejandrito commented Jul 31, 2020 •
edited
Loading

Things that definitely need to be improved:

  • Add chord picker modal based on tonaljs/chord.
  • Clearly show muted strings.
  • Make it easier to select common chords (major, minor...). The list of types is too long now.
  • Exclude impossible chord positions for 5 fingered humans.
  • Include chords that don't start with the root.
  • Include flat roots.
  • When a flat chord is detected the UI shows wrong notes.

Things that would be nice to add:

I've marked the new guitar-fretter package as private. I will:

  • Make it public when the logic is more polished.
@4lejandrito
Copy link
Owner Author

I've added a chord picker in #10. I'll keep this issue open since I consider it a work in progress.

@4lejandrito 4lejandrito mentioned this issue Nov 25, 2020
Closed
@RyanButton RyanButton mentioned this issue Jul 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@4lejandrito