More frets in viewport

[mrclay]

Had a couple ideas for you I could help implement if you're interested.

1. Make the frets a bit less wide to fit more in the viewport.
2. Have the frets narrow a bit going left to right like a real guitar.
3. Allow entry by shorthand (like x-4-2-0-0-0) or add that support in the URL.

Also I added a simple sequencer to my piano/chord tool, and I wonder if you'd mind if I borrowed your guitar sounds to add some flavors? Maybe I could have a mode allow entry by guitar voicings (x-4-2-0-0-0) and have each one link to react-guitar.

[4lejandrito]

Hi @mrclay!

Thanks for your suggestions:

1. The way I'd do this is using the Theme. We can add a new property to the fret object (something like width) and allow customizing it from there.
2. I think if we make the width property from point 1 a function that receives the fret number we can implement variable width frets.
3. Maybe we can expose a function in react-guitar that converts from shorthand to array of numbers and use it...

You can borrow anything from react-guitar, I'd be very happy 😄.

Feel free to have a go at implementing any of those things yourself. Otherwise let me know and I'll have a go at the weekend.

Thanks!