Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled solo-cli to flash pixhawk firmware from local drive #28

Merged
merged 5 commits into from
Nov 16, 2015
Merged

enabled solo-cli to flash pixhawk firmware from local drive #28

merged 5 commits into from
Nov 16, 2015

Conversation

ethliup
Copy link
Contributor

@ethliup ethliup commented Nov 13, 2015

No description provided.

@LorenzMeier
Copy link

Awesome! @liamstask can we get this in the fast track in terms of review and interaction? Thanks!

@tcr3dr
Copy link
Contributor

tcr3dr commented Nov 13, 2015

Hi @liupeidong88,

Can you change this to just be:

solo flash pixhawk <filename>

Since it's not an optional argument, we can just require the path/version/etc. as part of the arguments.

Otherwise, LGTM and I'll merge when the changes are made. Thanks!

@liamstask
Copy link

thanks for the PR @liupeidong88! i think it would be better to update the pixhawk without rebooting the system, which should be possible. i created #30 with a quick sketch of the shell commands that should be required.

any chance you could update this PR (or submit a new one) to use that approach?

@ethliup
Copy link
Contributor Author

ethliup commented Nov 16, 2015

@liamstask and @tcr3dr, I modified the command line and used loadPixhawk.py to flash pixhawk as requested. Please check them! If there is anything wrong, let me know.

@tcr3dr
Copy link
Contributor

tcr3dr commented Nov 16, 2015

lgtm

tcr3dr added a commit that referenced this pull request Nov 16, 2015
enabled solo-cli to flash pixhawk firmware from local drive
@tcr3dr tcr3dr merged commit a16aed1 into 3drobotics:master Nov 16, 2015
@liamstask
Copy link

@liupeidong88, @tcr3dr - does this work? concerned that there's no management of the system runlevel before updating.

@tcr3dr
Copy link
Contributor

tcr3dr commented Nov 17, 2015

@liamstask I'm unsure. Are you saying that the runlevel changes are not implemented from your branch? @liupeidong88

@liamstask
Copy link

i don't have a branch relevant to this PR, just saying that i do not see where in this PR that the runlevel is modified, to account for the firmware update.

@ethliup
Copy link
Contributor Author

ethliup commented Nov 17, 2015

@tcr3dr @liamstask I have fixed the run level management, sorry for it. Could you possible help test it again? It is evening in my place, or I can test it tomorrow.

Previously, I reboot it after uploading the firmware. Sometimes the flash procedure would be stuck at "waiting for boot loader." from px4_uploader.py. However, it works fine after I manually reboot it. I am unsure whether it is caused by the run-level management.

@ethliup
Copy link
Contributor Author

ethliup commented Nov 18, 2015

@tcr3dr @liamstask I tested it again. I found it would be stable if we could manually reboot it after uploading the firmware file with solo flash... I tried it several times with 2 firmware file, one is from 3-dr and another is our own, it never failed if I manually reboot it after uploading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants