-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled solo-cli to flash pixhawk firmware from local drive #28
Conversation
Awesome! @liamstask can we get this in the fast track in terms of review and interaction? Thanks! |
Hi @liupeidong88, Can you change this to just be:
Since it's not an optional argument, we can just require the path/version/etc. as part of the arguments. Otherwise, LGTM and I'll merge when the changes are made. Thanks! |
thanks for the PR @liupeidong88! i think it would be better to update the pixhawk without rebooting the system, which should be possible. i created #30 with a quick sketch of the shell commands that should be required. any chance you could update this PR (or submit a new one) to use that approach? |
@liamstask and @tcr3dr, I modified the command line and used loadPixhawk.py to flash pixhawk as requested. Please check them! If there is anything wrong, let me know. |
lgtm |
enabled solo-cli to flash pixhawk firmware from local drive
@liupeidong88, @tcr3dr - does this work? concerned that there's no management of the system runlevel before updating. |
@liamstask I'm unsure. Are you saying that the runlevel changes are not implemented from your branch? @liupeidong88 |
i don't have a branch relevant to this PR, just saying that i do not see where in this PR that the runlevel is modified, to account for the firmware update. |
@tcr3dr @liamstask I have fixed the run level management, sorry for it. Could you possible help test it again? It is evening in my place, or I can test it tomorrow. Previously, I reboot it after uploading the firmware. Sometimes the flash procedure would be stuck at "waiting for boot loader." from px4_uploader.py. However, it works fine after I manually reboot it. I am unsure whether it is caused by the run-level management. |
@tcr3dr @liamstask I tested it again. I found it would be stable if we could manually reboot it after uploading the firmware file with solo flash... I tried it several times with 2 firmware file, one is from 3-dr and another is our own, it never failed if I manually reboot it after uploading. |
No description provided.