Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 페이지네이션 컴포넌트 구현 #72

Merged
merged 15 commits into from
Jun 19, 2023
Merged

feat: 페이지네이션 컴포넌트 구현 #72

merged 15 commits into from
Jun 19, 2023

Conversation

dokimion24
Copy link
Collaborator

@dokimion24 dokimion24 commented Jun 19, 2023 •
edited
Loading

작업분류

  • 버그수정
  • 신규 기능
  • 리팩토링
  • 기타

작업내용

  • 페이지네이션 버튼 컴포넌트 구현
  • 개별 에셋 가져오기 기능
  • 페이지 별로 개별 에셋 보이기 기능

리뷰 요구사항

components/common/PaginationButton에 페이지네이션 버튼 컴포넌트 구현했습니다.
props

  • activePage (현재 페이지)
  • page ( 버튼 개수)
  • setActivePage (현재 페이지 설정)

변경 사항

@dokimion24
feat: ✨ type 설정, type 변경
022332f
@dokimion24
feat: ✨ 페이지별 에셋 가져오는 api 함수 작성
aedf3cd
@dokimion24
feat: ✨ asset 관련 타입 지정
003e177
@dokimion24
feat: ✨ individualAsset 개별에셋 컴포넌트 추가
d03bf13
@dokimion24
feat: ✨ asset type 수정, import 경로 수정
0715cf0
@dokimion24
feat: ✨ asset관련 타입 수정, 지정
c838979
@dokimion24
feat: ✨ 에셋 리스트 가져와 데이터 출력
baf570f
@dokimion24
feat: ✨ assets이 undefined일 때 처리
9d20c1c
@dokimion24
feat: ✨ 개별 에셋 컴포넌트 생성
cc2c356
@dokimion24
feat: ✨ 페이지네이션 버튼 기능 컴포넌트 구현
e44fae6
@dokimion24
feat: ✨ 에셋 가져오는 훅 수정
96d9644
@dokimion24
style: 💄 레이아웃 수정 스타일 수정
e192ae4
@dokimion24
chore: 🔨 style 포맷팅 적용
7ce265a
@dokimion24
feat: ✨ type 가드, 레이아웃 수정
c39c22c
@dokimion24
fix: 🐛 asset 제목 가져오기 수정
e6949fa
@vercel
Copy link

vercel bot commented Jun 19, 2023

@dokimion24 is attempting to deploy a commit to the neuroid-asset Team on Vercel.

A member of the Team first needs to authorize it.

@dokimion24 dokimion24 self-assigned this Jun 19, 2023
@dokimion24 dokimion24 added this to the 3차 Sprint milestone Jun 19, 2023
This was linked to issues Jun 19, 2023
[feat] 에셋 디테일 페이지 #41
Open
[feat] 개별 에셋 #70
Closed
ronieo
ronieo approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@ronieo ronieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
에셋 리뷰 페이지 QA진행 전에 한번 PR 주세요 :)

@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
3-d-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 7:35am

@ronieo ronieo merged commit 599e667 into 3DAsset-eCommerce:develop Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronieo ronieo ronieo approved these changes

Assignees

@dokimion24 dokimion24

Labels
Priority: Medium
Projects
None yet
Milestone
3차 Sprint
Development

Successfully merging this pull request may close these issues.

[feat] 에셋 디테일 페이지 [feat] 개별 에셋
2 participants
@dokimion24 @ronieo