Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource allocation script: relocate commands under "generate"? #3310

Closed
consideRatio opened this issue Oct 24, 2023 · 1 comment · Fixed by #3335
Closed

Resource allocation script: relocate commands under "generate"? #3310

consideRatio opened this issue Oct 24, 2023 · 1 comment · Fixed by #3335
Assignees
Labels
nominated-to-be-resolved-during-q4-2023 Nomination to be resolved during q4 goal of reducing the technical debt

Comments

@consideRatio
Copy link
Contributor

consideRatio commented Oct 24, 2023

#3030 added generate-resource-allocation-choices and update-node-capacity-info directly to the deployer's CLI main application, not under a sub application like deployer generate - I think we should relocate it there.

@consideRatio consideRatio changed the title Resource allocation script: make command visible Resource allocation script: relocate commands under "generate"? Oct 24, 2023
@yuvipanda
Copy link
Member

Yes, the script predated the generate subcommand. Moving is the right thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nominated-to-be-resolved-during-q4-2023 Nomination to be resolved during q4 goal of reducing the technical debt
Projects
No open projects
Status: Done 🎉
Development

Successfully merging a pull request may close this issue.

3 participants