Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass client configuration in 'new_client' function #99

Open
volodymyrZotov opened this issue Mar 20, 2024 · 1 comment
Open

Pass client configuration in 'new_client' function #99

volodymyrZotov opened this issue Mar 20, 2024 · 1 comment

Comments

@volodymyrZotov
Copy link
Contributor

Currently, there is no possibility of configuring httpx.Client when initializing the client using new_client function. The purpose of this issue to add the configuration ability to the new_client function so it would look like this:

def new_client(url: str, token: str, is_async: bool = False, config: httpx.BaseClient) -> Union[AsyncClient, Client]:

The config parameter should be of type httpx.BaseClient so we can pass any options that httpx.Client and httpx.AsyncClient have.

@chrismaddalena
Copy link

What is the status of this and the now-closed PR #96? We are trying to use Connect to manage secrets and integrate 1Password, but we have a private Certificate Authority. The Connect server has no issues, but even with the root CA cert installed on the hosts, new_client throws an error stating it can't verify the certificate. We're using the PR for now but would prefer to see this incorporated into an actual release so we aren't tied to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants