Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing credentials via credentials_base64 breaks the installation #94

Open
azerbe opened this issue Apr 10, 2022 · 2 comments
Open

Passing credentials via credentials_base64 breaks the installation #94

azerbe opened this issue Apr 10, 2022 · 2 comments
Labels
bug Something isn't working tracked Issue is tracked in 1Password's internal ticketing system as well.

Comments

@azerbe
Copy link

azerbe commented Apr 10, 2022

Your environment

Chart Version: 1.7.1

Helm Version: 3.8.1

Kubernetes Version: v1.23.4

What happened?

I am using the op cli tool to get the credentials.json from a 1Password vault and register it to an ansible variable. Then I'm base64 encoding the json and pass it to the helm-charts connect.credentials_base64 value.

Because of the stringData: type in the secret, the base64 value gets encoded again.

What did you expect to happen?

If a _base64 variable is provided, then it should be able to take values without using --set-file flags. This would make it compatible with different scenarios, where you don't want to store the credentials json in an actual file or retrieve it from a script.

Steps to reproduce

  1. Pass a base64 encoded credentials.json string to the connect.credentials_base64 value
@azerbe azerbe added the bug Something isn't working label Apr 10, 2022
@azerbe azerbe changed the title Passing credentials via credentials_base64 breaks because of stringData Passing credentials via credentials_base64 breaks the installation because of stringData Apr 10, 2022
@azerbe azerbe changed the title Passing credentials via credentials_base64 breaks the installation because of stringData Passing credentials via credentials_base64 breaks the installation Apr 10, 2022
@jillianwilson
Copy link
Contributor

Hi there, thanks for raising this issue. I can certainly see this being problematic for certain use cases. We will look into providing a good solution for this.

@edif2008 edif2008 added the tracked Issue is tracked in 1Password's internal ticketing system as well. label May 30, 2022
@volodymyrZotov
Copy link
Contributor

Should be solved in #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked Issue is tracked in 1Password's internal ticketing system as well.
Projects
None yet
Development

No branches or pull requests

4 participants