Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 compatibility #210

Closed
1 task done
rolf-yoast opened this issue Jul 2, 2024 · 3 comments · Fixed by #214
Closed
1 task done

PHP 8.3 compatibility #210

rolf-yoast opened this issue Jul 2, 2024 · 3 comments · Fixed by #214
Assignees
Labels
help wanted Extra attention is needed type:bug Something isn't working.
Milestone

Comments

@rolf-yoast
Copy link

Describe the bug

The plugin is using the ezyang/htmlpurifier library via composer. This library uses the get_magic_quotes_gpc function in https://github.com/ezyang/htmlpurifier/blob/master/library/HTMLPurifier/Config.php.

  1. But this function has been removed in PHP 8.0

Steps to Reproduce

  1. Go to https://github.com/ezyang/htmlpurifier/blob/master/library/HTMLPurifier/Config.php
  2. Search for get_magic_quotes_gpc and you can find it multiple times in the code
  3. Check https://www.php.net/manual/en/function.get-magic-quotes-gpc.php

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rolf-yoast rolf-yoast added the type:bug Something isn't working. label Jul 2, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Jul 2, 2024
@jeffpaul jeffpaul added this to the 2.3.0 milestone Jul 2, 2024
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jul 2, 2024
@darylldoyle
Copy link
Collaborator

@jeffpaul the new versions of the svg-sanitizer library dropped the use of the ezyang/htmlpurifier library. Updating enshrined/svg-sanitize to the latest version will solve this issue.

@rolf-yoast
Copy link
Author

@sksaju I see you've made a PR for this, thanks for that. But when will this be released? Any estimate on the ETA?

@jeffpaul jeffpaul moved this from To Do to Code Review in Open Source Practice Aug 14, 2024
@jeffpaul
Copy link
Member

@rolf-yoast there's some code review feedback on the linked PR that need to be resolved first, then we otherwise do a monthly check across our FOSS plugins to see which have something releasable. So unlikely that we see this get released until later in September at the earliest.

@faisal-alvi faisal-alvi moved this from Code Review to Done in Open Source Practice Sep 2, 2024
faisal-alvi added a commit that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants