Add a way to supply a fallback image to the Image component
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoetzer
reviewed
Oct 25, 2022
Comment on lines
+20
to
26
| "image": { | ||
| "type": "object", | ||
| "default": { | ||
| "id": null, | ||
| "fallback": null | ||
| } | ||
| }, |
There was a problem hiding this comment.
@fabiankaegy Essentially, I think we could have gone two ways about this:
- The way you approached it here by using a single prop structured as an object with two values, i.e.,
id&fallback, respectively. However, I'm just wondering about any possible confusion about what type of data needs to be provided for these two values, i.e., number vs. string. - OR perhaps it would be more clear (and less complex) to define the fallback image URL as a separate prop (optional), e.g.,
"imageId": {
"type": "number",
"default": null
},
"fallbackImageUrl": {
"type": "string",
"default": ""
}
…e-component # Conflicts: # components/image/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is an exploration of how we could potentially handle adding a fallback image option to the image component.
Closes #161
How to test the Change
Changelog Entry
Credits
Props @ncoetzer @sudar @ajmaurya99
Checklist: