added 3 additional standard banjo tunings: doubleCBanjo, doubleDBanjo… #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The whitespace in the strings does not seem consistent. Should we remove all the spaces to be consistent with the other tunings? |
I removed the extra spaces.
|
Thanks @jeremy9959! FYI: We're currently working on the next version of VexFlow (v5) over at: https://github.com/vexflow/vexflow/ The version here (version 4.x.y) is considered stable / LTS. Eventually we'll apply this PR to the new version as well. (If you end up trying out v5 and need your banjo changes, feel free to submit the PR again over at the v5 repo. Have a nice week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard banjo tuning is "Open G" but there are other tunings in common use. I've added three of them to the list of tuning names for convenience.