-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ornament delayed draw, such as on a grand staff. #1598
Conversation
Hi @RyoSusami, thanks for that! Would it be possible to add the testcase? |
@rvilarl |
just start duplicating one within ornament_test.ts |
@rvilarl |
I noticed that in the case above, the TickID order of TickContexts is 0,8192,4096, and the next context at the beginning of the lower voice is 8192, so the turn position is closer to the right than expected. |
Thanks a lot @RyoSusami ! |
When building a TickContext with multiple voices, such as a grand staff, the order of ticks was not continuous, so detection of the end of voice element failed and the Ornament display position was incorrect.
Before
After