Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Add further documentation to IBFT spec functions #238

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR adds addition explanation to how the maximum number of faulty nodes is calculated.

Closes issue #236.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@zivkovicmilos zivkovicmilos self-assigned this Nov 24, 2021
@zivkovicmilos zivkovicmilos linked an issue Nov 24, 2021 that may be closed by this pull request
@zivkovicmilos zivkovicmilos marked this pull request as draft November 24, 2021 15:41
@zivkovicmilos zivkovicmilos marked this pull request as ready for review November 24, 2021 15:56
Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice supplements 👏

Copy link
Contributor

@brkomir brkomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

consensus/ibft/state.go Outdated Show resolved Hide resolved
@zivkovicmilos zivkovicmilos merged commit 3941ec8 into develop Dec 7, 2021
@zivkovicmilos zivkovicmilos deleted the fix/conform-ibft-math branch December 7, 2021 12:33
munna0908 pushed a commit that referenced this pull request Dec 8, 2021
* Add further documentation to IBFT spec functions

* Simplify the MaxFaultyNodes method
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: MaxFaultyNodes and NumValid wrong math?
4 participants